potiuk commented on code in PR #51256:
URL: https://github.com/apache/airflow/pull/51256#discussion_r2143215570
##########
providers/git/src/airflow/providers/git/hooks/git.py:
##########
@@ -89,7 +90,7 @@ def _process_git_auth_url(self):
if not isinstance(self.repo_url, str):
return
if self.auth_token and self.repo_url.startswith("https://";):
- self.repo_url = self.repo_url.replace("https://";,
f"https://{self.auth_token}@";)
+ self.repo_url = self.repo_url.replace("https://";,
f"https://{self.user_name}:{self.auth_token}@";)
Review Comment:
OK. Sounds good to me - but I guess others who were more involved in git
provider development should chime in here. @dstandish @ephraimbuddy
@jedcunningham - if you have any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
