amoghrajesh commented on code in PR #51953:
URL: https://github.com/apache/airflow/pull/51953#discussion_r2158570744
##########
airflow-core/tests/unit/models/test_connection.py:
##########
@@ -255,6 +255,23 @@ def test_get_uri(self, connection, expected_uri):
def test_sanitize_conn_id(self, connection, expected_conn_id):
assert connection.conn_id == expected_conn_id
+ @pytest.mark.parametrize(
+ "conn_type, host",
+ [
+ # same protocol to type
+ ("http", "http://host";),
+ # different protocol to type
+ ("https", "http://host";),
Review Comment:
Yeah, i will not make the fix for now, we have tons of places where we do
not care what the type is in our tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
