ashb commented on code in PR #51953:
URL: https://github.com/apache/airflow/pull/51953#discussion_r2158746178
##########
airflow-core/tests/unit/models/test_connection.py:
##########
@@ -255,6 +255,23 @@ def test_get_uri(self, connection, expected_uri):
def test_sanitize_conn_id(self, connection, expected_conn_id):
assert connection.conn_id == expected_conn_id
+ @pytest.mark.parametrize(
+ "conn_type, host",
+ [
+ # same protocol to type
+ ("http", "http://host";),
+ # different protocol to type
+ ("https", "http://host";),
Review Comment:
I just meant ` ("http", "https://host";),` would be the "natural" way around.
Or did I read this diff to quickly and got it backwards.
Either way, not important for what the test is covering. Either way it tests
things correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
