bugraoz93 commented on code in PR #51657: URL: https://github.com/apache/airflow/pull/51657#discussion_r2164779702
########## airflow-core/src/airflow/api_fastapi/auth/managers/middleware/refresh_token.py: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging + +from fastapi import Request +from starlette.middleware.base import BaseHTTPMiddleware + +from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN, BaseAuthManager +from airflow.configuration import conf + +log = logging.getLogger(__name__) + + +class RefreshTokenMiddleware(BaseHTTPMiddleware): + """Middleware that refresh auth manager token and update JWT Token.""" + + def __init__(self, app, auth_manager: BaseAuthManager): + super().__init__(app) + self.auth_manager = auth_manager + + async def dispatch(self, request: Request, call_next): + # Extract Authorization header + auth = request.headers.get("authorization") + + if auth and auth.lower().startswith("bearer "): + token_str = auth.split(" ", 1)[1] + if token_str != "null": Review Comment: Yes, I also found it interesting. I first do with checking if it is None but end up seeking a lot of other things, thinking that this cannot be a string value. Since it is from UI, I assumed it should be the same for all the auth managers. ########## airflow-core/src/airflow/api_fastapi/auth/managers/middleware/refresh_token.py: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging + +from fastapi import Request +from starlette.middleware.base import BaseHTTPMiddleware + +from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN, BaseAuthManager +from airflow.configuration import conf + +log = logging.getLogger(__name__) + + +class RefreshTokenMiddleware(BaseHTTPMiddleware): + """Middleware that refresh auth manager token and update JWT Token.""" + + def __init__(self, app, auth_manager: BaseAuthManager): + super().__init__(app) + self.auth_manager = auth_manager + + async def dispatch(self, request: Request, call_next): + # Extract Authorization header + auth = request.headers.get("authorization") + + if auth and auth.lower().startswith("bearer "): + token_str = auth.split(" ", 1)[1] + if token_str != "null": Review Comment: Yes, I also found it interesting. I first check if it is None but end up seeking a lot of other things, thinking that this cannot be a string value. Since it is from UI, I assumed it should be the same for all the auth managers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
