vincbeck commented on code in PR #51657: URL: https://github.com/apache/airflow/pull/51657#discussion_r2167354746
########## airflow-core/src/airflow/api_fastapi/auth/managers/middleware/refresh_token.py: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging + +from fastapi import Request +from starlette.middleware.base import BaseHTTPMiddleware + +from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN, BaseAuthManager +from airflow.configuration import conf + +log = logging.getLogger(__name__) + + +class RefreshTokenMiddleware(BaseHTTPMiddleware): Review Comment: But if the token expires in the UI, it gets refreshed, then these APIs should be called with the new token? Actually it would be great to test this use case, if you could test that, that would be awesome. Ideally it should behave like this: - User hits the UI - RefreshTokenMiddle is executed - The user token is expired, it gets refreshed and sent back to the UI as cookie - The UI now uses this new token and should call the APIs using this new token But actually that could lead to some issues: - If there is an auto refresh, the token will not get refreshed and after 5 minutes all the calls will fail. So maybe we should not limit it to the UI? Sorry to go back and forth, I am discovering this feature while reviewing your PR :) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
