Dev-iL commented on code in PR #52233:
URL: https://github.com/apache/airflow/pull/52233#discussion_r2166276192
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -271,6 +271,22 @@ function check_boto_upgrade() {
set +x
}
+# Upgrade sqlalchemy to the latest version to run tests with it
+function check_upgrade_sqlalchemy() {
+ if [[ ${UPGRADE_SQLALCHEMY=} != "true" ]]; then
+ return
+ fi
+ echo
+ echo "${COLOR_BLUE}Upgrading sqlalchemy to the latest version to run tests
with it${COLOR_RESET}"
+ echo
+ set -x
+ # shellcheck disable=SC2086
+ ${PACKAGING_TOOL_CMD} uninstall ${EXTRA_UNINSTALL_FLAGS} flask-appbuilder
|| true
+ # shellcheck disable=SC2086
+ ${PACKAGING_TOOL_CMD} install ${EXTRA_INSTALL_FLAGS} --upgrade
"sqlalchemy[asyncio]<2.1" databricks-sqlalchemy
Review Comment:
Resolving because following an existing convention and refactoring it
everywhere is out of scope.
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -271,6 +271,22 @@ function check_boto_upgrade() {
set +x
}
+# Upgrade sqlalchemy to the latest version to run tests with it
+function check_upgrade_sqlalchemy() {
Review Comment:
Resolving because following an existing convention and refactoring it
everywhere is out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
