Copilot commented on code in PR #52233:
URL: https://github.com/apache/airflow/pull/52233#discussion_r2166321511
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -271,6 +271,22 @@ function check_boto_upgrade() {
set +x
}
+# Upgrade sqlalchemy to the latest version to run tests with it
+function check_upgrade_sqlalchemy() {
+ if [[ ${UPGRADE_SQLALCHEMY=} != "true" ]]; then
Review Comment:
For improved robustness and consistency with other conditionals in the
script, consider quoting the variable expansion (e.g., if [[
"${UPGRADE_SQLALCHEMY}" != "true" ]]) to avoid potential word splitting issues.
```suggestion
if [[ "${UPGRADE_SQLALCHEMY}" != "true" ]]; then
```
##########
Dockerfile.ci:
##########
@@ -1063,6 +1063,21 @@ function check_boto_upgrade() {
set +x
}
+function check_upgrade_sqlalchemy() {
+ if [[ ${UPGRADE_SQLALCHEMY=} != "true" ]]; then
Review Comment:
Consider quoting the variable expansion here as well (e.g., if [[
"${UPGRADE_SQLALCHEMY}" != "true" ]]) to prevent issues with word splitting and
maintain consistency with shell best practices.
```suggestion
if [[ "${UPGRADE_SQLALCHEMY=}" != "true" ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
