bugraoz93 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167048145
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
+ self,
+ sql,
Review Comment:
I think this seems shadow naming with below import, could cause problems
even though you added as psql there
`from pandas.io import sql as psql`
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
```suggestion
def get_pandas_df(
```
I think this shouldn't be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
