daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167884223
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, thanks for the review!
I went with this approach because it seemed like the safest option, as I’m
overriding a method from the superclass 'DbApiHook'. Since the base class calls
this method internally, changing its name would break the behavior. I
understand that overriding protected methods isn’t generally recommended, so if
there’s a better approach, I’m happy to consider it.
I also noticed that '_serialize_cell' is overridden in this class as well,
so I followed that pattern for consistency.
Any suggestions or feedback are more than welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
