dingo4dev commented on code in PR #52237:
URL: https://github.com/apache/airflow/pull/52237#discussion_r2168025122
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -529,7 +529,7 @@ def get_external_task_group_task_ids(self, session,
dttm_filter):
dttm_filter, self.external_task_group_id, self.external_dag_id,
session
)
- def _handle_execution_date_fn(self, context) -> Any:
+ def _handle_execution_date_fn(self, logical_date, context) -> Any:
Review Comment:
@bugraoz93 Thanks for review.
IMO, the backward compatibility is already handled in caller function, it is
better to keep consistent and align with the caller.
https://github.com/apache/airflow/blob/3576530b02631fd8f735baf01cb4d33342875198/providers/standard/src/airflow/providers/standard/sensors/external_task.py#L261-L273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
