bugraoz93 commented on PR #52237: URL: https://github.com/apache/airflow/pull/52237#issuecomment-3032837364
I agree with Pavan here, as I mentioned in my comment. It is breaking for `_handle_execution_date_fn`, and it could potentially be used by users. >IMO: The private method is intended for internal use only, and not expect external code to depend on these, though subclasses are an exception. But I couldn't find any subclass currently extend it. Please correct me if I am wrong. Normally, I agree that they should be private and not used, but from a user perspective, if it works via calling a private method to solve a problem, there is nothing stopping users from using and solving the problem without creating a public one or a custom bespoke solution in their local/envs. For example, you are creating your sensor extended from ExternalTaskSensor like `CustomSensor(ExternalTaskSensor)`. In this case, those methods are not counted as private since it will be just `super()._handle_execution_date_fn`, just a method from the extended class, where no external call is made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
