dominikhei commented on code in PR #51756:
URL: https://github.com/apache/airflow/pull/51756#discussion_r2174544046
##########
providers/tableau/docs/connections/tableau.rst:
##########
@@ -35,6 +35,12 @@ There are two ways to connect to Tableau using Airflow.
2. Use a `Token Authentication
<https://tableau.github.io/server-client-python/docs/api-ref#personalaccesstokenauth-class>`_
i.e. add a ``token_name`` and ``personal_access_token`` to the Airflow
connection (deprecated).
+3. Use `JSON Web Token (JWT) Authentication
+
<https://tableau.github.io/server-client-python/docs/sign-in-out.html#sign-in-with-json-web-token-jwt>`_
+ i.e add a ``jwt_file`` or a ``jwt_token`` to the Airflow connection extras.
+
+If both Password and Username authentication and JWT authentication are used
simultaneously,
+Password and Username authentication is preferred.
Review Comment:
My point of view was that as long as we document the behavior and only one
method is used, there is no harm in allowing both to be set at the same time.
But I'll adjust it, as one second thought there is more speaking against than
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
