pierrejeambrun commented on code in PR #52437:
URL: https://github.com/apache/airflow/pull/52437#discussion_r2177844986
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -334,6 +336,7 @@ def get_dag_runs(
readable_dag_runs_filter: ReadableDagRunsFilterDep,
session: SessionDep,
dag_bag: DagBagDep,
+ run_id: Annotated[_SearchParam,
Depends(search_param_factory(DagRun.run_id, "run_id"))],
Review Comment:
`run_id_pattern` to match other search query param in the API.
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -289,7 +313,16 @@ export const DagRuns = () => {
))}
</Select.Content>
</Select.Root>
- </Flex>
+
+ <InputGroup startElement={<FiHash size={14} />}>
+ <Input
+ maxW="200px"
+ onChange={handleRunIdChange}
+ placeholder={translate("dags:filters.runIdFilter")}
Review Comment:
```suggestion
placeholder={translate("dags:filters.runIdPatternFilter")}
```
##########
airflow-core/src/airflow/ui/src/constants/searchParams.ts:
##########
@@ -26,6 +26,7 @@ export enum SearchParamsKeys {
OFFSET = "offset",
PAUSED = "paused",
POOL = "pool",
+ RUN_ID = "run_id",
Review Comment:
RUN_ID_PATTERN="run_id_pattern"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
