noeunkim commented on code in PR #52437:
URL: https://github.com/apache/airflow/pull/52437#discussion_r2179059832
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -289,7 +313,16 @@ export const DagRuns = () => {
))}
</Select.Content>
</Select.Root>
- </Flex>
+
+ <InputGroup startElement={<FiHash size={14} />}>
+ <Input
+ maxW="200px"
+ onChange={handleRunIdChange}
+ placeholder={translate("dags:filters.runIdFilter")}
+ value={filteredRunId ?? ""}
+ />
+ </InputGroup>
Review Comment:
Nice suggestion!
I’m actually open to UI feedback because there are many ways to support
`run_id` filter (for example, using dropdown like previous version) that’s why
I initially created new component
but based on the current discussion `reusing the existing SearchBar` makes
sense for me :-)
just applied it:
[6b7507](https://github.com/apache/airflow/pull/52437/commits/6b750748b94ce5b7afd042dab46fcd21543cd67e#diff-b534f087a86da3b506e704ff503a46fe0cad686ddfbdf0a2428e857b96852958L318)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
