noeunkim commented on code in PR #52437:
URL: https://github.com/apache/airflow/pull/52437#discussion_r2183033012
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##########
@@ -464,6 +464,20 @@ def test_bad_limit_and_offset(self, test_client,
query_params, expected_detail):
},
[DAG1_RUN2_ID],
),
+ (DAG1_ID, {"run_id": DAG1_RUN1_ID}, [DAG1_RUN1_ID]),
+ (DAG2_ID, {"run_id": DAG2_RUN1_ID}, [DAG2_RUN1_ID]),
+ ("~", {"run_id": DAG1_RUN1_ID}, [DAG1_RUN1_ID]),
+ ("~", {"run_id": "non_existent_run_id"}, []),
+ (DAG1_ID, {"run_id": "%run_1%"}, [DAG1_RUN1_ID]),
+ ("~", {"run_id": "%dag_run_%"}, [DAG1_RUN1_ID, DAG1_RUN2_ID,
DAG2_RUN1_ID, DAG2_RUN2_ID]),
Review Comment:
Nice feedback! I updated it and also added one more case to show explicit
pattern matching:
https://github.com/apache/airflow/pull/52437/commits/1ece0de03a8d40a8f101bff1ef7511932de866fe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
