pierrejeambrun commented on code in PR #52437:
URL: https://github.com/apache/airflow/pull/52437#discussion_r2184793990
##########
airflow-core/src/airflow/ui/src/components/SearchBar.test.tsx:
##########
@@ -25,7 +25,7 @@ import { SearchBar } from "./SearchBar";
describe("Test SearchBar", () => {
it("Renders and clear button works", async () => {
- render(<SearchBar defaultValue="" onChange={vi.fn()} placeHolder="Search
Dags" />, {
+ render(<SearchBar defaultValue="" hideAdvanced={false} onChange={vi.fn()}
placeHolder="Search Dags" />, {
Review Comment:
As you saw there, the default you chose is updating the behavior of other
components outside the scope of your work. Maybe you should keep
`hideAdvanced=false` and set it to True in the DagRun search bar only.
Because beside testing all the searchbar of the entire application, we can't
know for sure that this won't break advanced search of other Searchbars.
What was the motivation to update the default value of the SearchBar
component in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
