ashb commented on code in PR #53020:
URL: https://github.com/apache/airflow/pull/53020#discussion_r2192738577
##########
task-sdk/src/airflow/sdk/bases/xcom.py:
##########
@@ -306,7 +307,17 @@ def get_all(
if not isinstance(msg, XComSequenceSliceResult):
raise TypeError(f"Expected XComSequenceSliceResult, received:
{type(msg)} {msg}")
- return msg.root
+ result = deserialize(msg.root)
+ if not result:
+ log.warning(
+ "No XCom value(s) found; defaulting to None.",
+ key=key,
+ dag_id=dag_id,
+ task_id=task_id,
+ run_id=run_id,
+ )
Review Comment:
This warning is not right -- it's going to be essentially noise in the users
task logs, and is not actually a warning -- it's the intended behaviour of the
user, else they wouldn't have passed in a default value for us to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
