amoghrajesh commented on code in PR #53020:
URL: https://github.com/apache/airflow/pull/53020#discussion_r2192808083
##########
task-sdk/src/airflow/sdk/bases/xcom.py:
##########
@@ -306,7 +307,17 @@ def get_all(
if not isinstance(msg, XComSequenceSliceResult):
raise TypeError(f"Expected XComSequenceSliceResult, received:
{type(msg)} {msg}")
- return msg.root
+ result = deserialize(msg.root)
+ if not result:
+ log.warning(
+ "No XCom value(s) found; defaulting to None.",
+ key=key,
+ dag_id=dag_id,
+ task_id=task_id,
+ run_id=run_id,
+ )
Review Comment:
Makes sense, removing it. What would you think about similar stuff for
`get_one` too? I guess similar stuff should be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
