kaxil commented on PR #52868: URL: https://github.com/apache/airflow/pull/52868#issuecomment-3056115078
> @ashb and I had a brief discussion regarding `ApprovalOperator`, which was previously a `HITLOperator` with its options set to `Approve` and `Reject`, and does nothing more. It may surprise some users if they select `Reject` and the process still proceeds. (which is still a valid use case, but users can also achieve them through `HITLBranchOperator`, or inherit `HITLOperator`). So we're thinking of merging `HITLTerminationOperator` into `ApprovelOperator` and treat "Reject" as "Stop" What would be the use-case of the opposite -- i.e. "Reject" but still continue with the following tasks? Similar to Ash, I was assuming the "Approval" to be similar to Circle CI approval step ([source](https://circleci.com/blog/adding-approval-jobs-to-your-ci-pipeline/#:~:text=Just%20like%20that%2C%20selecting%20Approve%20makes%20the%20API%20call%20back%20to%20CircleCI%20to%20approve%20the%20pipeline%20and%20deploy%20your%20code%20to%20production.)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
