jscheffl commented on PR #52868: URL: https://github.com/apache/airflow/pull/52868#issuecomment-3058859104
> > > @ashb and I had a brief discussion regarding `ApprovalOperator`, which was previously a `HITLOperator` with its options set to `Approve` and `Reject`, and does nothing more. It may surprise some users if they select `Reject` and the process still proceeds. (which is still a valid use case, but users can also achieve them through `HITLBranchOperator`, or inherit `HITLOperator`). So we're thinking of merging `HITLTerminationOperator` into `ApprovelOperator` and treat "Reject" as "Stop" > > > > > > What would be the use-case of the opposite -- i.e. "Reject" but still continue with the following tasks? Similar to Ash, I was assuming the "Approval" to be similar to Circle CI approval step ([source](https://circleci.com/blog/adding-approval-jobs-to-your-ci-pipeline/#:~:text=Just%20like%20that%2C%20selecting%20Approve%20makes%20the%20API%20call%20back%20to%20CircleCI%20to%20approve%20the%20pipeline%20and%20deploy%20your%20code%20to%20production.)) > > One example that comes to mind is the content moderation process described in the AIP-90 document. When a moderator approves content, it would be best for the system to simply terminate without taking any further action. On the other hand, if the content is rejected, it could lead to post deletions or other consequences, depending on the designed use case. I’m okay with it and have already updated the operator, as users can utilize other operators to achieve the same outcome. I assume if you want to have follow-up actions on "Reject" then the branching operator type is more suited. I would see the "Approval" with Reject rather as a function like a ShortCircuit... but no strong feelings. Just feels more intuitive when I re-think... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
