ashb commented on code in PR #50192:
URL: https://github.com/apache/airflow/pull/50192#discussion_r2210831830
##########
kubernetes-tests/tests/kubernetes_tests/test_kubernetes_pod_operator.py:
##########
@@ -183,6 +184,7 @@ def test_do_xcom_push_defaults_false(self, kubeconfig_path,
mock_get_connection,
)
assert not k.do_xcom_push
+ @pytest.mark.asyncio
Review Comment:
I don't think you should need this -- It's likely needed to make
`asyncio.get_event_loop()` pass, but a worker doesn't have it, and if we swap
it to `aysncio.run()` it won't need this marker. I.e. adding this mark was
working around the test failing in a way that is not respective of how the KPO
actually runs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
