ashb commented on code in PR #50192:
URL: https://github.com/apache/airflow/pull/50192#discussion_r2211068207
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -602,12 +603,20 @@ def get_or_create_pod(self, pod_request_obj: k8s.V1Pod,
context: Context) -> k8s
def await_pod_start(self, pod: k8s.V1Pod) -> None:
try:
- self.pod_manager.await_pod_start(
- pod=pod,
- schedule_timeout=self.schedule_timeout_seconds,
- startup_timeout=self.startup_timeout_seconds,
- check_interval=self.startup_check_interval_seconds,
+ loop = asyncio.get_event_loop()
Review Comment:
I don't have many details -- its second hand through one of the Astronomer
customers.
I think this is something turning the deprecation warning in to an error --
I think the fix/workaround is to swap the manual loop control to `asyncio.run`
as per this in the docs
> Application developers should typically use the high-level asyncio
functions, such as `asyncio.run()`, and should rarely need to reference the
loop object or call its methods. This section is intended mostly for authors of
lower-level code, libraries, and frameworks, who need finer control over the
event loop behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
