zach-overflow commented on code in PR #53397: URL: https://github.com/apache/airflow/pull/53397#discussion_r2210861913
########## airflow-core/docs/core-concepts/auth-manager/index.rst: ########## @@ -178,6 +181,8 @@ The following methods aren't required to override to have a functional Airflow a * ``batch_is_authorized_dag``: Batch version of ``is_authorized_dag``. If not overridden, it will call ``is_authorized_dag`` for every single item. * ``get_authorized_dag_ids``: Return the list of DAG IDs the user has access to. If not overridden, it will call ``is_authorized_dag`` for every single DAG available in the environment. + * Note: The ``get_authorized_dag_ids`` may be of particular interest if you rely on per-DAG access controls derived from one or more fields on a given DAG (e.g. DAG tags). Review Comment: Oh that's interesting, thank you for bringing that to my attention. Are you saying that the `get_authorized_dag_ids` should not be considered part of the public Auth Manager interface? If so, I'd be interested in helping make that an optionally overridable component of the interface. The reason being that it could allow for optimizations at the query level, while also giving more expressive options for DAG ownership inference via DAG attributes (again, like DAG tags). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
