vincbeck commented on code in PR #53397: URL: https://github.com/apache/airflow/pull/53397#discussion_r2210960558
########## airflow-core/docs/core-concepts/auth-manager/index.rst: ########## @@ -178,6 +181,8 @@ The following methods aren't required to override to have a functional Airflow a * ``batch_is_authorized_dag``: Batch version of ``is_authorized_dag``. If not overridden, it will call ``is_authorized_dag`` for every single item. * ``get_authorized_dag_ids``: Return the list of DAG IDs the user has access to. If not overridden, it will call ``is_authorized_dag`` for every single DAG available in the environment. + * Note: The ``get_authorized_dag_ids`` may be of particular interest if you rely on per-DAG access controls derived from one or more fields on a given DAG (e.g. DAG tags). Review Comment: No, `get_authorized_dag_ids` should be part of the auth manager interface. In that sense, users are free to override it but they are more expected to not override it. On the other side `filter_authorized_dag_ids`, is more expected to be overridden. But you are right, if they want to, users are free to override `get_authorized_dag_ids` to make optimizations on the query level, at their own risks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
