choo121600 opened a new pull request, #53701:
URL: https://github.com/apache/airflow/pull/53701
This PR adds automatic formatting for i18n JSON files via a pre-commit hook
and resolves formatting inconsistencies in existing translation files.
## Backgroud
The existing pre-commit hook only checks for missing `TODO` entries, but
does not validate formatting.
Because of this, files with inconsistent formatting could still be committed
without any warnings, So it hard to maintain consistency across translations.
## Change
I modified `scripts/ci/pre_commit/check_i18n_json.py` to enforce a
consistent JSON format by applying the following:
``` python
json.dumps(parsed_json, indent=2, ensure_ascii=False, sort_keys=False) + "\n"
```
* indent=2: Sets 2-space indentation
* ensure_ascii=False: Prevents escaping of Unicode characters
* sort_keys=False: Key sorting is handled separately
* Appends \n to ensure a trailing newline
These settings are now enforced via a pre-commit hook, ensuring that
formatting is applied automatically on commit.
All existing translation files have been reformatted accordingly.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
