pierrejeambrun commented on code in PR #53652:
URL: https://github.com/apache/airflow/pull/53652#discussion_r2231221753
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##########
@@ -577,6 +577,179 @@ def test_invalid_state(self, test_client):
)
+class TestTriggeringUserNamePatternFilter:
Review Comment:
You don't need to create a dedicated class for testing this new parameter.
Can you please update the test file to integrate it to the current file.
Probably modifying the setup to have some triggering user name, and then
adding stuff to `def test_filters`.
That will keep the structure cleaner and it will be easer to locate all
tests regarding parametes.
##########
airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:
##########
@@ -257,6 +276,15 @@ export const DagRuns = () => {
placeHolder={translate("dags:filters.runIdPatternFilter")}
/>
</Box>
+ <Box>
+ <SearchBar
+ defaultValue={filteredTriggeringUserNamePattern ?? ""}
+ hideAdvanced
+ hotkeyDisabled={true}
+ onChange={handleTriggeringUserNamePatternChange}
+ placeHolder={translate("dags:filters.triggeringUserNameFilter")}
+ />
Review Comment:
The placeholder is truncated a little bit. We should probably let the input
expand to have the full text displayed.
<img width="961" height="270" alt="Screenshot 2025-07-25 at 16 22 46"
src="https://github.com/user-attachments/assets/14b17473-39f3-4fe7-8f71-4d466217d68b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
