dheerajturaga commented on code in PR #53652:
URL: https://github.com/apache/airflow/pull/53652#discussion_r2236780948
##########
airflow-core/src/airflow/ui/src/components/SearchBar.tsx:
##########
@@ -32,7 +32,7 @@ const debounceDelay = 200;
type Props = {
readonly buttonProps?: ButtonProps;
readonly defaultValue: string;
- readonly groupProps?: InputGroupProps;
+ readonly groupProps?: Omit<InputGroupProps, "children">;
Review Comment:
The SearchBar component internally controls its own children prop when
rendering the InputGroup. Using the full InputGroupProps type created a
conflict because external code could try to override the internal children. see
`airflow-core/src/airflow/ui/src/pages/DagRuns.tsx:282`
Omit<InputGroupProps, "children"> prevents this conflict by excluding the
children prop from the external interface while allowing all other InputGroup
customizations.
Breeze static checks caught this type conflict and I had to make this
correction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
