Re: [PR] Add UI for human in the loop operators [airflow]

Wed, 30 Jul 2025 02:19:47 -0700 


Lee-W commented on PR #53035:
URL: https://github.com/apache/airflow/pull/53035#issuecomment-3135490248

   > > To check if we should display or not the HITL tab, we query the TI HITL 
details, this cause multiple 404 not found errors for tasks that do not have 
HITL.
   > > We should probably handle this nicely in the UI. Like this is not an 
error, catch it and return empty HITL, and keep going with that. <img 
alt="Screenshot 2025-07-29 at 13 34 47" width="1920" height="753" 
src="https://private-user-images.githubusercontent.com/14861206/471971070-9c97d67d-89c9-4875-be37-8decb4570a39.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTM4MTQwMzIsIm5iZiI6MTc1MzgxMzczMiwicGF0aCI6Ii8xNDg2MTIwNi80NzE5NzEwNzAtOWM5N2Q2N2QtODljOS00ODc1LWJlMzctOGRlY2I0NTcwYTM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzI5VDE4Mjg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3ZDFlZTMzNWEwNmI3YjdjNThmN2Y5YWMwMTY5Y2Q5ZDNiMTI5MzdkYmY0MmUzZTU5YmFiYTA1NTM2ODEwODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zoaWqS8dhfCnllu8XTLiCI0rqat-qBmWzFi5LRT1XzE";>
   > 
   > I rewrote the original implementation. Previously, it determined whether 
to render by checking if a 404 was returned, but that doesn’t seem like the 
best practice. So instead, I chose to use getDetails and then filter the 
results. Since getDetails is usually cached, I thought this might be better, 
but I think the best practice might actually be to add a taskId filter to 
getDetails. What do you think about that?
   > 
   > cc: @Lee-W
   
   I can create a taskId filter. will send a PR today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to