Lee-W commented on code in PR #53035:
URL: https://github.com/apache/airflow/pull/53035#discussion_r2242051894
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/hitl.json:
##########
@@ -0,0 +1,23 @@
+{
+ "actionRequired_one": "Action Required",
+ "actionRequired_other": "Actions Required",
+ "response": {
+ "error": "Response failed",
+ "optionsDescription": "Choose your options for this task instance",
+ "optionsLabel": "Options",
+ "received": "Response received at ",
+ "respond": "Respond",
+ "success": "{{taskId}} response successful",
+ "title": "Human Task Instance - {{taskId}}"
+ },
+ "status": {
+ "approvalReceived": "Approval Received",
+ "approvalRequired": "Approval Required",
+ "choiceReceived": "Choice Received",
+ "choiceRequired": "Choice Required",
+ "inputReceived": "Input Received",
+ "inputRequired": "Input Required",
+ "responseReceived": "Response Received",
+ "responseRequired": "Response Required"
Review Comment:
It may not be a good idea. It could be confusing to someone familiar with
airflow. If we were to do that, I would like to propose adding a new column
`HITL state` (which could be renamed) instead of changing the task state. Or
something like `... Received (Success)` or `Approval Required (deferred)` can
be a reasonable middle ground. Also, the task state does not directly relate to
whether the responses are received. One can easily design an `HITLOperator`
that fails when a response received
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
