pierrejeambrun commented on code in PR #54163:
URL: https://github.com/apache/airflow/pull/54163#discussion_r2257653037
##########
airflow-core/src/airflow/ui/src/pages/Run/Header.tsx:
##########
@@ -43,6 +43,10 @@ export const Header = ({
const { t: translate } = useTranslation();
const [note, setNote] = useState<string | null>(dagRun.note);
+ useEffect(() => {
+ setNote(dagRun.note);
+ }, [dagRun.note]);
+
Review Comment:
Why do we have those two useEffect added? It seems unrelated.
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Header.tsx:
##########
@@ -64,6 +64,10 @@ export const Header = ({
const [note, setNote] = useState<string | null>(taskInstance.note);
+ useEffect(() => {
+ setNote(taskInstance.note);
+ }, [taskInstance.note]);
+
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
