dheerajturaga commented on PR #54163:
URL: https://github.com/apache/airflow/pull/54163#issuecomment-3160818739

   > I think there is two things that we can improve for note visibility:
   > 
   > 1. Find a way to identify quickly which dag/ti contains a note across 
multiple runs/tis. In AF3 we had a small transparency marker on the grid to 
indicate that and I think it was a smart way of achieving it.
   > 2. Find a way to display the note in a more natural way and drag attention 
of users to the note, so they do not miss it before performing any action on 
the TI or DagRun. |
   > 
   > For 1) I tend to think that the way we did it in AF2 was actually good, 
but I'm open to other suggestions.
   > 
   > For 2) I think that button coloring or some 'notification' marker on the 
button could drag user attention that there is a note here. Embedding the note 
directly in the main details tab is tricky for the reason mentioned in Jens PR. 
And if we end up putting it in a dedicated tab, it's still extra clicks to get 
there. For instance maybe a simple 'notification' indicator on the button, 
similarly to what github is doing could be nice: <img alt="Screenshot 
2025-08-06 at 18 13 01" width="60" height="46" 
src="https://private-user-images.githubusercontent.com/14861206/475110588-6f26a5bd-c39d-4d32-9764-cce9c001bfa9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTQ0OTczMjcsIm5iZiI6MTc1NDQ5NzAyNywicGF0aCI6Ii8xNDg2MTIwNi80NzUxMTA1ODgtNmYyNmE1YmQtYzM5ZC00ZDMyLTk3NjQtY2NlOWMwMDFiZmE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MD
 
YlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODA2VDE2MTcwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY1ZmExZmZiZTVhYmIwNDE1NTJlNDZiZDcyMWJkYzllMTczMDRkMjAzMWFhYzJkZDg0YmI1YjI4MmNmYTQ5ZTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.6HxcHm13tziWy-l8G2p6wdlUZurlAkwYlnZbbA6ugsg">
   > 
   > <img alt="Screenshot 2025-08-06 at 18 14 53" width="80" height="73" 
src="https://private-user-images.githubusercontent.com/14861206/475111307-b678f885-7bbd-4100-b873-7be3b796d960.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTQ0OTczMjcsIm5iZiI6MTc1NDQ5NzAyNywicGF0aCI6Ii8xNDg2MTIwNi80NzUxMTEzMDctYjY3OGY4ODUtN2JiZC00MTAwLWI4NzMtN2JlM2I3OTZkOTYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODA2VDE2MTcwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4YmI0YjAwMGYxNzM1YjgzMTk3YTc3NDVlNDAxOTllYmY1OGI3OThjNjVkYzQzZTk2YTM0ZmY2MzZjMjhkNTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4b5WZARLkGf69AO-k1fiai687kVhLPREfd_BzkjU3i8";>
   
   For 1. Transparency marker is good, however it also displayed the note in 
the dag run page which was very helpful personally. I do agree that pushing 
down the dag runs to accommodate the notes can get visually unappealing if the 
note is very large. I dont think these notes get large in general though... 
   
   For 2. The way github does notifications is not really eye catching. I 
really like the big colored buttons which are very obvious especially for 
things like "Note" because you want to invite viewers to see whats going on for 
that run. On that note I like github's way of highlighting PRs 
   <img width="898" height="85" alt="image" 
src="https://github.com/user-attachments/assets/73a75e80-4570-4a70-932f-d7bf1a5d264e";
 />
   
   Im open to any other suggestions to make this more visible
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to