sjyangkevin commented on code in PR #51511:
URL: https://github.com/apache/airflow/pull/51511#discussion_r2258681366
##########
airflow-core/tests/unit/dag_processing/test_collection.py:
##########
@@ -340,10 +345,7 @@ def dag_to_lazy_serdag(self, dag: DAG) ->
LazyDeserializedDAG:
ser_dict = SerializedDAG.to_dict(dag)
return LazyDeserializedDAG(data=ser_dict)
- @pytest.mark.skipif(
- condition="FabAuthManager" not in conf.get("core", "auth_manager"),
- reason="This is only for FabAuthManager",
- )
+ @mark_fab_auth_manager_test
Review Comment:
Thanks, I see. The current method uses the `from airflow.configuration
import conf` to load airflow configuration. This only works when we specify
`--keep-env-variables`. The reason is as follow when I asked the question in
slack channel.
>The thing is that we are clearing all AIRFLOW__ variables in
pytest_plugin.py (except a few like SQLALCHEMY etc.) -> to assure
reproducibility of the tests
Interesting in learning more about it to understand the benefits this
approach over the existing one. Will look into it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
