sjyangkevin commented on code in PR #51511:
URL: https://github.com/apache/airflow/pull/51511#discussion_r2268273073
##########
airflow-core/tests/unit/dag_processing/test_collection.py:
##########
@@ -340,10 +345,7 @@ def dag_to_lazy_serdag(self, dag: DAG) ->
LazyDeserializedDAG:
ser_dict = SerializedDAG.to_dict(dag)
return LazyDeserializedDAG(data=ser_dict)
- @pytest.mark.skipif(
- condition="FabAuthManager" not in conf.get("core", "auth_manager"),
- reason="This is only for FabAuthManager",
- )
+ @mark_fab_auth_manager_test
Review Comment:
Hi @potiuk , thanks for the detailed feedback again, and I have a quick
follow up question related to this test case. As @Lee-W suggested, probably we
can mock the env variables to run this test. From my understanding, it might
not require the explicitly run test with `--keep-env-variables`. Do you think
it is a good direction we can go with to improve this test? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
