jason810496 commented on code in PR #53821:
URL: https://github.com/apache/airflow/pull/53821#discussion_r2271894987
##########
providers/elasticsearch/src/airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -331,9 +334,10 @@ def _read(
# end_of_log_mark may contain characters like '\n' which is needed to
# have the log uploaded but will not be stored in elasticsearch.
+ print(f"self.end_of_log_mark = {self.end_of_log_mark}")
metadata["end_of_log"] = False
if logs_by_host:
- if any(x[-1].message == self.end_of_log_mark for x in
logs_by_host.values()):
+ if any(x[-1].event == self.end_of_log_mark for x in
logs_by_host.values()):
metadata["end_of_log"] = True
Review Comment:
Yes, we need to handle `.message` with `.event` depends on airflow-core
version.
The c17147dca735aa1f6501711e8897b41c9aa6dab1 commit resolved the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
