Owen-CH-Leung commented on code in PR #53821:
URL: https://github.com/apache/airflow/pull/53821#discussion_r2287782628
##########
providers/elasticsearch/src/airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -189,6 +208,21 @@ def __init__(
self.handler: logging.FileHandler | logging.StreamHandler | None = None
self._doc_type_map: dict[Any, Any] = {}
self._doc_type: list[Any] = []
+ self.io = ElasticsearchRemoteLogIO(
+ host=self.host,
+ target_index=self.target_index,
+ write_stdout=self.write_stdout,
+ write_to_es=self.write_to_es,
+ offset_field=self.offset_field,
+ host_field=self.host_field,
+ base_log_folder=base_log_folder,
+ delete_local_copy=self.delete_local_copy,
+ )
+ # Airflow 3 introduce REMOTE_TASK_LOG for handling remote logging
+ # REMOTE_TASK_LOG should be explicitly set in
airflow_local_settings.py when trying to use ESTaskHandler
+ # Before airflow 3.1, REMOTE_TASK_LOG is not set when trying to use ES
TaskHandler.
+ if AIRFLOW_V_3_0_PLUS and alc.REMOTE_TASK_LOG is None:
+ alc.REMOTE_TASK_LOG = self.io
Review Comment:
In Airflow 3.0.3 and 3.0.4, we still use `ElasticsearchTaskHandler`, so
`REMOTE_TASK_LOG ` is always None during initialization. This ensures that the
write-to-ES feature remains backward-compatible with these patch versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
