amoghrajesh commented on code in PR #54449:
URL: https://github.com/apache/airflow/pull/54449#discussion_r2292792685
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -253,10 +253,6 @@ def run(self):
By processing them in separate processes, we can get parallelism and
isolation
from potentially harmful user code.
"""
- from airflow.sdk.execution_time.secrets_masker import
reset_secrets_masker
-
- reset_secrets_masker()
Review Comment:
Yep, we do not need it anymore because we are using module level global
maskers now. The dag processor and triggerer uses masker from sdk symlink path.
Earlier it used to be ONE masker globally added in the log filters
(airflow.task i think) that was passed around and reused. Reference:
https://github.com/apache/airflow/pull/54449#discussion_r2284573333 that I had
tested
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -514,10 +518,6 @@ def _handle_request(self, msg: ToTriggerSupervisor, log:
FilteringBoundLogger, r
def run(self) -> None:
"""Run synchronously and handle all database reads/writes."""
- from airflow.sdk.execution_time.secrets_masker import
reset_secrets_masker
-
- reset_secrets_masker()
Review Comment:
Same as https://github.com/apache/airflow/pull/54449#discussion_r2292792685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
