amoghrajesh commented on code in PR #54449:
URL: https://github.com/apache/airflow/pull/54449#discussion_r2293183778
##########
shared/secrets_masker/src/airflow_shared/secrets_masker/secrets_masker.py:
##########
@@ -206,6 +202,8 @@ class SecretsMasker(logging.Filter):
ALREADY_FILTERED_FLAG = "__SecretsMasker_filtered"
MAX_RECURSION_DEPTH = 5
_has_warned_short_secret = False
+ # Private variable with method access
+ _mask_secrets_in_logs = False
Review Comment:
Yeah it should instead be a public variable but user experience wise calling
a method for setting / getting would be more convenient than:
`SecretsMasker.mask_secrets_in_logs = True`
Ref: https://github.com/apache/airflow/pull/54449#discussion_r2291331166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
