ashb commented on code in PR #54693: URL: https://github.com/apache/airflow/pull/54693#discussion_r2304209419
########## devel-common/src/docs/shared/template-examples/taskflow-kwargs.rst: ########## @@ -17,15 +17,14 @@ .. code-block:: python - from airflow.models.taskinstance import TaskInstance - from airflow.models.dagrun import DagRun + from airflow.sdk.api.datamodels._generated import DagRun Review Comment: This isn't right. Users (and thus our docs) should almost never import anything in SDK outside of the `airflow.sdk` module itself, and definitely not from a `_private` module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
