obarisk commented on code in PR #54693: URL: https://github.com/apache/airflow/pull/54693#discussion_r2306438296
########## devel-common/src/docs/shared/template-examples/taskflow-kwargs.rst: ########## @@ -17,15 +17,14 @@ .. code-block:: python - from airflow.models.taskinstance import TaskInstance - from airflow.models.dagrun import DagRun + from airflow.sdk.api.datamodels._generated import DagRun + from airflow.sdk.execution_time.task_runner import RuntimeTaskInstance Review Comment: And note, as far as I know, the attributes/methods are different between `airflow.models.dagrun.DagRun` and `airflow.sdk.api.datamodels._generated.dagRun` the type hint will give the user non-existed methods/attributes when using ```py from airflow.models.taskinstance import TaskInstance ``` ---- or maybe this is not a document issue. but instead we have to modify the definiation of `airflow.models.taskinstance.TaskInstance` itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
