jason810496 commented on code in PR #55193:
URL: https://github.com/apache/airflow/pull/55193#discussion_r2317680408
##########
airflow-core/tests/unit/models/test_connection.py:
##########
@@ -355,3 +357,14 @@ def test_get_connection_from_secrets_metastore_backend(
# Verify the backends were called
mock_env_backend.assert_called_once_with(conn_id="test_conn")
mock_db_backend.assert_called_once_with(conn_id="test_conn")
+
+ @pytest.mark.db_test
+ def test_get_team_name(self, testing_team, session):
Review Comment:
```suggestion
def test_get_team_name(self, testing_team: Team, session: Session):
```
##########
airflow-core/tests/unit/models/test_variable.py:
##########
@@ -311,6 +311,13 @@ def test_cache_invalidation_on_set(self, session):
assert c != b
+ def test_get_team_name(self, testing_team, session):
Review Comment:
```suggestion
def test_get_team_name(self, testing_team: Team, session: Session):
```
##########
airflow-core/src/airflow/models/pool.py:
##########
@@ -352,3 +353,9 @@ def open_slots(self, session: Session = NEW_SESSION) ->
float:
if self.slots == -1:
return float("inf")
return self.slots - self.occupied_slots(session)
+
Review Comment:
Do we need to add `team_id` parameter in constructor for Pool as well ?
##########
airflow-core/tests/unit/models/test_pool.py:
##########
@@ -319,3 +319,10 @@ def test_is_default_pool(self):
default_pool = Pool.get_default_pool()
assert not Pool.is_default_pool(id=pool.id)
assert Pool.is_default_pool(str(default_pool.id))
+
+ def test_get_team_name(self, testing_team, session):
Review Comment:
```suggestion
def test_get_team_name(self, testing_team: Team, session: Session):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
