vincbeck commented on code in PR #55193:
URL: https://github.com/apache/airflow/pull/55193#discussion_r2319709924
##########
airflow-core/src/airflow/models/pool.py:
##########
@@ -352,3 +353,9 @@ def open_slots(self, session: Session = NEW_SESSION) ->
float:
if self.slots == -1:
return float("inf")
return self.slots - self.occupied_slots(session)
+
Review Comment:
I think @jason810496 refers to the constructor. The reason why I did not add
it to the constructor is, there is no constructor defined in `Pool` so it uses
the default one provided by `airflow.models.base.Base`. And with this
constructor you can pass any property of the model when creating the object. If
you look at `test_pool.py` in this PR, I create a Pool with `Pool(pool="test",
include_deferred=False, team_id=testing_team.id)`, so I use conveniently the
default constructor :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
