uranusjr commented on code in PR #55160:
URL: https://github.com/apache/airflow/pull/55160#discussion_r2314846386


##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/event_logs.py:
##########
@@ -41,6 +41,9 @@ class EventLogResponse(BaseModel):
     dag_display_name: str | None = Field(
         validation_alias=AliasPath("dag_model", "dag_display_name"), 
default=None
     )
+    task_display_name: str | None = Field(
+        validation_alias=AliasPath("task_instance", "task_display_name"), 
default=None
+    )

Review Comment:
   I don’t think this can ever be None? TaskInstance always defaults to task_id 
if the column does not contain a value.
   
   Actually dag_display_name also cannot be None as far as I can tell. Maybe we 
should fix it too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to