guan404ming commented on code in PR #55160:
URL: https://github.com/apache/airflow/pull/55160#discussion_r2315588677
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/event_logs.py:
##########
@@ -41,6 +41,9 @@ class EventLogResponse(BaseModel):
dag_display_name: str | None = Field(
validation_alias=AliasPath("dag_model", "dag_display_name"),
default=None
)
+ task_display_name: str | None = Field(
+ validation_alias=AliasPath("task_instance", "task_display_name"),
default=None
+ )
Review Comment:
I think it might be null. Since `dag_id` and `task_id`can also be `None`
here, it means the relationships to `dag_model` and `task_instance` can be
`None`, which indicates that `display_name` is possible to be `None`.
However, when they do exist, the display names should always be never `None`
as confirmed by the hybrid property logic like what you said. Please let me
know if I've misunderstood anything, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
