albundy83 commented on code in PR #52953:
URL: https://github.com/apache/airflow/pull/52953#discussion_r2353143841
##########
chart/templates/secrets/webserver-secret-key-secret.yaml:
##########
@@ -20,7 +20,7 @@
############################################
## Airflow Webserver Flask Secret Key Secret
############################################
-{{- if and (semverCompare "<3.0.0" .Values.airflowVersion)
.Values.webserver.enabled (not .Values.webserverSecretKeySecretName) }}
+{{- if and (semverCompare "<3.0.0" .Values.airflowVersion) (not
.Values.webserverSecretKeySecretName) }}
Review Comment:
This is an issue that I introduced in a previous
[commit](https://github.com/apache/airflow/commit/45b93094eb0447c891a11cfd4ef08d5b30d8aad6#diff-d95e2ce6ff33952802af4a04bd20e160005f40817d246e9b4964410d6b7e8c7e).
If you disable the webserver, it doesn't necessarily mean that you don't
need the webserver Secret.
For example, if you deploy Airflow components in separate namespaces.
It was an issue [here](https://github.com/apache/airflow/issues/53375) that
made me realize this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
