romsharon98 commented on code in PR #52953:
URL: https://github.com/apache/airflow/pull/52953#discussion_r2352486916
##########
chart/templates/_helpers.yaml:
##########
@@ -473,7 +473,7 @@ If release name contains chart name it will be used as a
full name.
{{- end }}
{{- define "kerberos_keytab_secret" -}}
- {{- printf "%s-kerberos-keytab" (include "airflow.fullname" .) }}
+ {{- default (printf "%s-kerberos-keytab" (include "airflow.fullname" .))
.Values.kerberos.keytabBase64Content }}
Review Comment:
Can you explain this change?
##########
chart/templates/api-server/api-server-ingress.yaml:
##########
@@ -76,7 +76,7 @@ spec:
pathType: {{ .pathType }}
backend:
service:
- name: {{ .serviceName }}
+ name: {{ $fullname }}-api-server
Review Comment:
I think we want to keep the serviceName
##########
chart/templates/secrets/webserver-secret-key-secret.yaml:
##########
@@ -20,7 +20,7 @@
############################################
## Airflow Webserver Flask Secret Key Secret
############################################
-{{- if and (semverCompare "<3.0.0" .Values.airflowVersion)
.Values.webserver.enabled (not .Values.webserverSecretKeySecretName) }}
+{{- if and (semverCompare "<3.0.0" .Values.airflowVersion) (not
.Values.webserverSecretKeySecretName) }}
Review Comment:
why you removed it?
##########
chart/templates/api-server/api-server-ingress.yaml:
##########
@@ -94,7 +94,7 @@ spec:
pathType: {{ .pathType }}
backend:
service:
- name: {{ .serviceName }}
+ name: {{ $fullname }}-api-server
Review Comment:
also here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
