ashb commented on code in PR #55833:
URL: https://github.com/apache/airflow/pull/55833#discussion_r2359542290
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -3784,16 +3784,32 @@ class LazyDeserializedDAG(pydantic.BaseModel):
last_loaded: datetime.datetime | None = None
NULLABLE_PROPERTIES: ClassVar[set[str]] = {
- "is_paused_upon_creation",
+ # Non attr fields that should be nullable, or attrs with a different
default
"owner",
+ "owner_links",
"dag_display_name",
+ # Attr properties that are nullable, or have a default that loads from
config
"description",
- "relative_fileloc",
+ "start_date",
+ "end_date",
+ "template_searchpath",
+ "user_defined_macros",
+ "user_defined_filters",
"max_active_tasks",
"max_active_runs",
"max_consecutive_failed_dag_runs",
- "owner_links",
+ "dagrun_timeout",
+ "deadline",
+ "catchup",
+ "on_success_callback",
+ "on_failure_callback",
Review Comment:
```suggestion
```
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -3784,16 +3784,32 @@ class LazyDeserializedDAG(pydantic.BaseModel):
last_loaded: datetime.datetime | None = None
NULLABLE_PROPERTIES: ClassVar[set[str]] = {
- "is_paused_upon_creation",
+ # Non attr fields that should be nullable, or attrs with a different
default
"owner",
+ "owner_links",
"dag_display_name",
+ # Attr properties that are nullable, or have a default that loads from
config
Review Comment:
```suggestion
"has_on_success_callback",
"has_on_failure_callback",
# Attr properties that are nullable, or have a default that loads
from config
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
