kaxil commented on code in PR #55833:
URL: https://github.com/apache/airflow/pull/55833#discussion_r2359538126
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -3784,16 +3784,32 @@ class LazyDeserializedDAG(pydantic.BaseModel):
last_loaded: datetime.datetime | None = None
NULLABLE_PROPERTIES: ClassVar[set[str]] = {
- "is_paused_upon_creation",
+ # Non attr fields that should be nullable, or attrs with a different
default
"owner",
+ "owner_links",
"dag_display_name",
+ # Attr properties that are nullable, or have a default that loads from
config
"description",
- "relative_fileloc",
+ "start_date",
+ "end_date",
+ "template_searchpath",
+ "user_defined_macros",
+ "user_defined_filters",
"max_active_tasks",
"max_active_runs",
"max_consecutive_failed_dag_runs",
- "owner_links",
+ "dagrun_timeout",
+ "deadline",
+ "catchup",
+ "on_success_callback",
+ "on_failure_callback",
Review Comment:
Change it, since SerializedDag itself would never have that attrib
```py
(Pdbr) set(vars(expected).keys())
{'description', 'disable_bundle_versioning', 'catchup', 'access_control',
'start_date', 'dag_dependencies', 'max_consecutive_failed_dag_runs',
'deadline', 'render_template_as_native_obj', 'max_active_runs',
'edge_info', 'owner_links', 'task_group', 'is_paused_upon_creation',
'max_active_tasks', '_processor_dags_folder', 'tags', 'relative_fileloc',
'last_loaded', 'default_args', 'dag_id', 'dag_display_name',
'end_date', 'task_dict', 'fail_fast', 'dagrun_timeout', 'timetable',
'partial', 'template_searchpath', 'has_on_success_callback', 'timezone',
'doc_md', 'fileloc', 'has_on_failure_callback', 'params'}
```
`expected` is var of one of my tests cases in
https://github.com/apache/airflow/pull/55836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
