ashb commented on code in PR #55836:
URL: https://github.com/apache/airflow/pull/55836#discussion_r2359502778
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2780,10 +2780,10 @@ def _create_compat_timetable(value):
def from_dict(cls, serialized_obj: dict) -> SerializedDAG:
"""Deserializes a python dict in to the DAG and operators it
contains."""
ver = serialized_obj.get("__version", "<not present>")
- if ver not in (1, 2):
+ if ver not in (1, 2, 3):
raise ValueError(f"Unsure how to deserialize version {ver!r}")
if ver == 1:
- cls.conversion_v1_to_v2(serialized_obj)
+ cls.conversion_v1_to_v3(serialized_obj)
Review Comment:
It feels odd to not change v2 to v3 even if that is a no-op upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
