kaxil commented on code in PR #55836:
URL: https://github.com/apache/airflow/pull/55836#discussion_r2359583742
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2780,10 +2780,10 @@ def _create_compat_timetable(value):
def from_dict(cls, serialized_obj: dict) -> SerializedDAG:
"""Deserializes a python dict in to the DAG and operators it
contains."""
ver = serialized_obj.get("__version", "<not present>")
- if ver not in (1, 2):
+ if ver not in (1, 2, 3):
raise ValueError(f"Unsure how to deserialize version {ver!r}")
if ver == 1:
- cls.conversion_v1_to_v2(serialized_obj)
+ cls.conversion_v1_to_v3(serialized_obj)
Review Comment:
Done in
https://github.com/apache/airflow/pull/55836/commits/adc60844482360fa26b4ac1acfa03839ccd243ae
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2646,7 +2646,7 @@ def to_dict(cls, var: Any) -> dict:
return json_dict
@staticmethod
- def conversion_v1_to_v2(ser_obj: dict):
+ def conversion_v1_to_v3(ser_obj: dict):
Review Comment:
Done in
https://github.com/apache/airflow/pull/55836/commits/adc60844482360fa26b4ac1acfa03839ccd243ae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
