uranusjr commented on code in PR #57465:
URL: https://github.com/apache/airflow/pull/57465#discussion_r2471872838
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -447,7 +446,7 @@ def _create_ti_state_update_query_and_update_state(
session: SessionDep,
dag_bag: DagBagDep,
dag_id: str,
-) -> tuple[Update, TaskInstanceState]:
+) -> tuple[Update, str]:
Review Comment:
Hmm, I think the return type is the correct here, and we should keep it. The
`updated_state` argument here is actually meaningless and should be removed.
The input argument in `ti_update_state` is also meaningless. I’ll submit a
separate PR to change it to make sense; this PR can be rebased once that’s
merged into main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
